Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs:文档修正 #2392

Merged
merged 1 commit into from
Mar 8, 2019
Merged

docs:文档修正 #2392

merged 1 commit into from
Mar 8, 2019
+1 −1

Conversation

JohannLai
Copy link
Contributor

fix #2390

@yuche yuche merged commit 911a692 into NervJS:master Mar 8, 2019
@JohannLai JohannLai deleted the hotfix/fix-docs-tutorial branch March 8, 2019 08:00
@taro-bot taro-bot bot mentioned this pull request Mar 9, 2019
Closed
Garfield550
Garfield550 reviewed Mar 9, 2019
View reviewed changes
Copy link
Collaborator

@Garfield550 Garfield550 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 PR 依旧有个拼写错误，Did 的小写 d 被误写成大写 D

docs/tutorial.md
@@ -616,7 +616,7 @@ export default class Index extends Component {

页面卸载时触发，如 redirectTo 或 navigateBack 到其他页面时

#### componentDiShow()
#### componentDiDShow()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
你改了一次还是改错了...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不好意思，我再改一下

@JohannLai JohannLai mentioned this pull request Mar 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garfield550 Garfield550 Garfield550 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

文档错误
3 participants
@JohannLai @Garfield550 @yuche